<html>
<head><meta charset="utf-8"><title>revert #76030 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/revert.20.2376030.html">revert #76030</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="220267032"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/revert%20%2376030/near/220267032" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/revert.20.2376030.html#220267032">(Dec 17 2020 at 16:35)</a>:</h4>
<p>After doing a revert of <a href="https://github.com/rust-lang/rust/issues/76030">#76030</a> locally (as <a href="#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.20meeting.5D.202020-12-17.20.2354818/near/220261541">requested in today's meeting</a>), I'm noticing a test failure for <a href="https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-75763.rs"><code>issue-75763.rs</code></a>:</p>
<div class="codehilite"><pre><span></span><code>thread &#39;rustc&#39; panicked at &#39;non utf8 str from miri: Utf8Error { valid_up_to: 0, error_len: Some(1) }&#39;, compiler/rustc_middle/src/ty/print/pretty.rs:1125:52
</code></pre></div>
<p>Should I just adjust this test so that it is expected to ICE? It seems like the non-utf8 str is exactly what the test was added for.</p>



<a name="220267062"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/revert%20%2376030/near/220267062" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/revert.20.2376030.html#220267062">(Dec 17 2020 at 16:35)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="216206">@lcnr</span></p>



<a name="220267270"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/revert%20%2376030/near/220267270" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/revert.20.2376030.html#220267270">(Dec 17 2020 at 16:37)</a>:</h4>
<p>ignore the test and add a <code>FIXME(const_generics)</code></p>



<a name="220267280"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/revert%20%2376030/near/220267280" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lcnr <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/revert.20.2376030.html#220267280">(Dec 17 2020 at 16:37)</a>:</h4>
<p>is probably the easiest for now</p>



<a name="220267418"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/revert%20%2376030/near/220267418" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/revert.20.2376030.html#220267418">(Dec 17 2020 at 16:38)</a>:</h4>
<p>thanks!</p>



<a name="220268156"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/revert%20%2376030/near/220268156" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> davidtwco <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/revert.20.2376030.html#220268156">(Dec 17 2020 at 16:43)</a>:</h4>
<p>(<a href="https://github.com/rust-lang/rust/issues/80122">#80122</a> has the revert)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>